engine: do not stall the host command queue on a failed send in Agent… - #14040
Open
nagaboinaramgopal wants to merge 1 commit into
Open
engine: do not stall the host command queue on a failed send in Agent…#14040nagaboinaramgopal wants to merge 1 commit into
nagaboinaramgopal wants to merge 1 commit into
Conversation
DaanHoogland
reviewed
Sep 2, 2026
nagaboinaramgopal
force-pushed
the
fix/agentattache-sendnext-stall
branch
from
September 2, 2026 23:20
b280ae5 to
b42f357
Compare
nagaboinaramgopal
force-pushed
the
fix/agentattache-sendnext-stall
branch
from
September 3, 2026 17:19
b42f357 to
dab7711
Compare
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #14040 +/- ##
============================================
+ Coverage 16.34% 17.21% +0.86%
- Complexity 13574 13580 +6
============================================
Files 5669 5264 -405
Lines 501368 468343 -33025
Branches 60903 55005 -5898
============================================
- Hits 81964 80632 -1332
+ Misses 410219 378694 -31525
+ Partials 9185 9017 -168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 19095 |
Contributor
|
@nagaboinaramgopal , an compile error in your test code: can you have a look? |
…Attache.sendNext When sending the next queued request threw AgentUnavailableException, the request was cancelled but _currentSequence was still set to that dead sequence. No answer ever arrives for a cancelled command, so sendNext was never driven again and every later in-sequence command to the host queued behind it and timed out until the attache was rebuilt. Advance _currentSequence only on a successful send, and on failure move on to the next queued request.
nagaboinaramgopal
force-pushed
the
fix/agentattache-sendnext-stall
branch
from
September 4, 2026 11:31
dab7711 to
4d8e427
Compare
Author
fixed and pushed, Thanks Daan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When sending the next queued request threw AgentUnavailableException, the request
was cancelled but _currentSequence was still set to that dead sequence. No answer
ever arrives for a cancelled command, so sendNext was never driven again and every
later in-sequence command to the host queued behind it and timed out, until the
attache was rebuilt.
Advance _currentSequence only on a successful send, and on failure move on to the
next queued request.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Added a unit test where the first queued command fails to send and asserts the
next queued command is dispatched and becomes the current sequence, instead of
stalling on the failed one. Also built the standard packages and deployed on a KVM
advanced zone.